Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "=" between --kokkos-tools-args and argument #264

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

cwpearson
Copy link
Contributor

@cwpearson cwpearson commented Jul 16, 2024

A user at LANL tried --kokkos-tools-args 10 and received an error during Kokkos::initialize(). They needed to do --kokkos-tools-args=10

@cwpearson cwpearson requested a review from crtrott July 16, 2024 21:51
@dalg24
Copy link
Member

dalg24 commented Jul 16, 2024

Out of curiosity what error did we print? (Wondering if that needs improvement too)

@dalg24 dalg24 merged commit 5e895a3 into kokkos:develop Jul 16, 2024
7 checks passed
@cwpearson
Copy link
Contributor Author

I'm pretty sure it was this case:

https://github.com/kokkos/kokkos/blob/8e682582fd8302008ce5e422377e4ef2d730c23b/core/src/impl/Kokkos_Profiling.cpp#L127-L129

it was confusing because it just said

Warning: command line argument --kokkos-tools-args is not recognized

@dalg24
Copy link
Member

dalg24 commented Jul 17, 2024

I'm pretty sure it was this case:

https://github.com/kokkos/kokkos/blob/8e682582fd8302008ce5e422377e4ef2d730c23b/core/src/impl/Kokkos_Profiling.cpp#L127-L129

it was confusing because it just said

Warning: command line argument --kokkos-tools-args is not recognized

No way. We explicitly guard with
https://github.com/kokkos/kokkos/blob/8e682582fd8302008ce5e422377e4ef2d730c23b/core/src/impl/Kokkos_Profiling.cpp#L125-L126

I spoke too fast. OK we can definitely do better than that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants