Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prevent perfetto-connector from breaking Kokkos Tools CI #270

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

vlkale
Copy link
Contributor

@vlkale vlkale commented Sep 5, 2024

Fix problem with chunk size that occurs with different compile time configurations. This is expected to fix Kokkos Tools Issue #259.

This PR is part of an effort to breaks down PR #262 into two separate pieces. This piece focuses on the Perfetto connector fix, while the other is on allowing for Debian interactive mode and ensuring the latest versions of CMake.

@masterleinad
Copy link
Contributor

Fix problem with chunk size that occurs with different compile time configurations. This is expected to fix Kokkos Tools Issue #259.

Which compiler configuration deosn't allow using sizeof in a constexpr context?

@vlkale
Copy link
Contributor Author

vlkale commented Sep 5, 2024

Fix problem with chunk size that occurs with different compile time configurations. This is expected to fix Kokkos Tools Issue #259.

Which compiler configuration deosn't allow using sizeof in a constexpr context?

@masterleinad It's cuda-11.0.3 from ubuntu, and there could be others, given the error seen. Actually, this draft PR doesn't capture the full changes at the moment. Look at PR #262 to see the full changes.

Details:

  1. I put this as draft but in process of trying refactor this draft PR to remove any use of CUDA 11.0.3 in the CI. I will update the title with NOTHING TO SEE HERE. Feel free to comment here, but better would be PR CI test with CUDA 11.0 + Perfetto connector fix (bringing PR 212 to completion) #262.

  2. Note that constexpr problem you refer to is not the only fix in CI test with CUDA 11.0 + Perfetto connector fix (bringing PR 212 to completion) #262 that is to come here - the primary problem with perfetto-connector is BUILTIN_CLOCK.

  3. The problem remaining for CUDA 11.0.3 is with nvcc_wrapper - see the CI test for CUDA 11.0.3 in CI test with CUDA 11.0 + Perfetto connector fix (bringing PR 212 to completion) #262. I think there is a problem involving the docker container - my goal is to make that a separate GitHub PR so that the other changes made in PR CI test with CUDA 11.0 + Perfetto connector fix (bringing PR 212 to completion) #262 can be merged.

@vlkale vlkale changed the title Fix chunk in perfetto.cc for perfetto-connector [NOTHING TO SEE HERE] Fix chunk in perfetto.cc for perfetto-connector Sep 5, 2024
@vlkale vlkale changed the title [NOTHING TO SEE HERE] Fix chunk in perfetto.cc for perfetto-connector [WIP] Fix chunk in perfetto.cc for perfetto-connector Sep 5, 2024
@vlkale vlkale changed the title [WIP] Fix chunk in perfetto.cc for perfetto-connector [WIP] Prevent perfetto-connector from breaking CI Sep 5, 2024
@vlkale vlkale changed the title [WIP] Prevent perfetto-connector from breaking CI [WIP] Prevent perfetto-connector from breaking CI for CUDA compilers Sep 5, 2024
@vlkale vlkale changed the title [WIP] Prevent perfetto-connector from breaking CI for CUDA compilers [WIP] Prevent perfetto-connector from breaking Kokkos Tools CI Sep 5, 2024
@crtrott crtrott marked this pull request as ready for review September 5, 2024 20:28
@crtrott crtrott merged commit a9453b2 into kokkos:develop Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants