requirements.txt: Updated python version >=3.9, <3.12 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there’s a problem with Python 3.12, that probably just means the pybind11 submodule needs to be updated, bc it looks like it hasn’t been updated in 2 years |
|
I will check it out, thanks! |
NaderAlAwar
requested changes
Jan 19, 2024
requirements.txt
Outdated
| @@ -1,3 +1,4 @@ | |||
| cmake>=3.16 | |||
| python>3.9,<3.12 | |||
There was a problem hiding this comment.
This is incorrect, should be >= 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly adding supported python versions in requirements.txt, as the setup or pykokkos is currently incompatible outside this range.
Previously the environment defaulted to the latest python package (at this time 3.12.x), which is not supported.