ENH: add() to API standard #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bring the `add()` ufunc up to the API standard and turn the relevant test on in the CI * other changes are similar to other recent binary ufunc PRs; note one drawback related to copies in broadcasting * the changes are similar to those in kokkosgh-156, though more workunit type implementation were needed for this operation to pass the standard test
tylerjereddy
added
enhancement
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Jan 16, 2023
* bring the `subtract()` ufunc up to the API standard, and turn the matching test on in the CI * this is similar to kokkosgh-157, with similar broadcasting memory drawback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring the
add()ufunc up to the API standard and turn the relevant test on in the CIother changes are similar to other recent binary ufunc PRs; note one drawback related to copies in broadcasting
the changes are similar to those in ENH: divide() to API standard #156, though more workunit type implementations were needed for this operation to pass the standard test