Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator generation + Polished type Inference #211

Merged
merged 15 commits into from
Nov 8, 2023

Conversation

HannanNaeem
Copy link
Contributor

In continuation to previous version of type inference, now introducing a series of improvements:

  • Decorator specifiers logic has been made separate from type inference - and these decorators will always override user provided ones
  • Refactored to simplify type inference
  • Keyword arguments can now be passed in any order with respect to the signature for inference to work
  • Separated AST injection/fix calls for type annotation insertion and decorator insertion

@HannanNaeem HannanNaeem marked this pull request as ready for review October 30, 2023 22:15
Copy link
Contributor

@NaderAlAwar NaderAlAwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor changes required

pykokkos/core/parsers/parser.py Outdated Show resolved Hide resolved
pykokkos/interface/args_type_inference.py Outdated Show resolved Hide resolved
pykokkos/interface/args_type_inference.py Outdated Show resolved Hide resolved
pykokkos/interface/args_type_inference.py Outdated Show resolved Hide resolved
pykokkos/interface/args_type_inference.py Outdated Show resolved Hide resolved
pykokkos/interface/args_type_inference.py Outdated Show resolved Hide resolved
tests/test_typeinference.py Outdated Show resolved Hide resolved
@NaderAlAwar NaderAlAwar merged commit 1c6e3e6 into kokkos:main Nov 8, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants