Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Set up for building our image and running tests/code #212

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

gliga
Copy link
Contributor

@gliga gliga commented Nov 2, 2023

The goal of this PR is to enable us to run pykokkos in a docker container. The items included:

  • Dockerfile to let us build the image (this is focusing on CPU runs at the moment)
  • Script that can use pykkokos image to run tests and examples in a container
  • requirements.txt to ensure more control over versioning

Some decision decisions:

  • Use pykokkos as the name for the image (note that later we might add other images for -cuda or -hip). Maybe -cpu could be added, but I did not feel like it.
  • Use pk as the username (because I felt there are many pykokkos things around already).
  • Potentially went a bit too far with being strict on version numbers, but felt good about it (as we can relax things in the future)

One thing we will probably want to add into the pk script is to pull the the pykokkos image if one is not present.

@NaderAlAwar NaderAlAwar merged commit e9bc8af into main Nov 3, 2023
4 of 5 checks passed
@gliga gliga deleted the docker branch November 20, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants