Improve performance of kernel fusion by eliminating unnecessary deep copy #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is compiled since it is costly
gliga
reviewed
Nov 22, 2023
gliga
reviewed
Nov 22, 2023
NaderAlAwar
changed the title
…ion corresponding to a workunit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
deepcopy()from the parser when retrieving workunits to avoid unnecessary overhead. Previously it was done for every workunit AST since fusion requires that we modify the ASTs. We stilldeepcopy()but only for fused workunits and only after we check whether the fused workunit has already been compiled, greatly reducing the overhead by PyKokkos.