Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Updated python version >=3.9, <3.12 #250

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

HannanNaeem
Copy link
Contributor

Explicitly defining the range of python versions supported -- this PR has a counterpart in pykokkos-base as well.

requirements.txt Outdated
@@ -2,4 +2,4 @@ pybind11>=2.11.1
cupy>=12.2.0
patchelf>=0.17.2
pytest>=7.4.3
python=3.11
python>3.9,<3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, should be >= 3.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought I put 3.8

@NaderAlAwar NaderAlAwar merged commit 58a0ab8 into kokkos:main Jan 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants