A few small fixes for compilation and installation #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
requested changes
Dec 8, 2021
| @@ -47,6 +47,10 @@ | |||
| #include "maybe_static_size.hpp" | |||
| #include "layout_tags.hpp" | |||
|
|
|||
| #include <experimental/__p0009_bits/macros.hpp> | |||
There was a problem hiding this comment.
The P1673 implementation shouldn't be depending on P0009 implementation details. Would you consider instead just including the main mdspan header, <experimental/mdspan>? Thanks!
dalg24
reviewed
Dec 8, 2021
| @@ -122,7 +122,7 @@ install(TARGETS linalg EXPORT linalgTargets | |||
| install(EXPORT linalgTargets | |||
| FILE linalgTargets.cmake | |||
| NAMESPACE std:: | |||
| DESTINATION cmake | |||
| DESTINATION lib/cmake/stdBLAS | |||
There was a problem hiding this comment.
Should be lib/cmake/<ProjectName> so stdBLAS -> linalg?
There was a problem hiding this comment.
Ah, yes, that's right, thanks for the catch!
|
@lums658 I'm a bit occupied today, but if you're too busy to push the requested changes, would you mind if we did it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was to get compilation and installation working with g++-11 on MacOS. Added a few "typename" here and there in a couple of files. Also changed "cmake" to lib/cmake/stdBLAS for installing the stdBLAS cmake file(s).
I note that compilation is only possible with -std=c++20 now -- many uses of concepts and requires clauses throughout.