Fix vector idx abs max #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iburyl
commented
Sep 28, 2024
iburyl
commented
- renamed idx_abs_max -> vector_idx_abs_max
- aligned behavior for complex values with the spec (that is abs is not really abs)
- Currently if NaN is in the first position output is 0. Output will ignore NaNs in any other position and will provide an index of the max value, ignoring all other NaNs. NaNs are checked the same way as in BLAS (that is not really checked). NaN behavior is not clarified with spec. Anything beyond that implementation will have cross-board performance implications. Leave NaNs to unspecified output.
crtrott
requested changes
Sep 28, 2024
The previous used (revised in linalg adoption process) used abs(z) for complex. Now its abs(z.real()) + abs(z.imag()). The test wasn't sensitive to the change.
|
I pushed a change to the test which makes it sensitive to the changed behavior for complex. It wasn't before (i.e. the test passed before and with your change). |
crtrott
approved these changes
Sep 28, 2024
|
@mhoemmen if you also approve I merge (or you can merge and we consider that approval) |
mhoemmen
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.