Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for vector_sum_of_squares and renaming for vector_norm2 #291

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix for vector_sum_of_squares and renaming for vector_norm2 #291

merged 2 commits into from
Oct 1, 2024

Conversation

iburyl
Copy link
Contributor

@iburyl iburyl commented Sep 30, 2024

  1. implementation for vector_sum_of_squares was completely broken - fixed
  2. vector_norm2 renamed to vecotr_two_norm (as it was done in p1673r12)

@iburyl
Copy link
Contributor Author

iburyl commented Sep 30, 2024

sequencies in tests are monotonically increasing in abs values, thus broken branch is never touched

mhoemmen
mhoemmen approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilya! : - )

@mhoemmen mhoemmen merged commit de4f137 into kokkos:main Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iburyl @mhoemmen