Add Readme and some tests to :erc961 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigman212
commented
Oct 14, 2023
| // as defined in http://eips.ethereum.org/EIPS/eip-831 | ||
|
|
||
| /** | ||
| * as defined in [EIP-831](https://eips.ethereum.org/EIPS/eip-831) |
There was a problem hiding this comment.
do I understand that 831 is not yet approved ERC, but still EIP?
There was a problem hiding this comment.
yea - still need to push this through the EIP process
bigman212
commented
Oct 14, 2023
| fun parseERC831(url: String): ERC831 = EthereumURI(url).toERC831() |
There was a problem hiding this comment.
just explicit types and some wraps that are added by the Intellij
|
@ligi ❤️ |
ligi
approved these changes
Oct 26, 2023
| // as defined in http://eips.ethereum.org/EIPS/eip-831 | ||
|
|
||
| /** | ||
| * as defined in [EIP-831](https://eips.ethereum.org/EIPS/eip-831) |
There was a problem hiding this comment.
yea - still need to push this through the EIP process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.