-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Readme and some tests to :erc961 #157
Conversation
// as defined in http://eips.ethereum.org/EIPS/eip-831 | ||
|
||
/** | ||
* as defined in [EIP-831](https://eips.ethereum.org/EIPS/eip-831) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I understand that 831 is not yet approved ERC, but still EIP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea - still need to push this through the EIP process
fun parseERC831(url: String): ERC831 = EthereumURI(url).toERC831() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just explicit types and some wraps that are added by the Intellij
@ligi ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks and sorry for the late merge
// as defined in http://eips.ethereum.org/EIPS/eip-831 | ||
|
||
/** | ||
* as defined in [EIP-831](https://eips.ethereum.org/EIPS/eip-831) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea - still need to push this through the EIP process
No description provided.