Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/67 #113

Merged
merged 119 commits into from
May 31, 2019
Merged

Issues/67 #113

merged 119 commits into from
May 31, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 28, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • Introduce a configurable timeout when trying to connect to SMSC
  • Try and detect when the connection to SMSC is disconnected and attempt to re-connect & re-bind
  • bugfix; asyncio.streams.StreamWriter.drain should not be called concurrently by multiple coroutines[1]
  • when shutting down, naz now tries to make sure that write buffers are properly flushed[2][3]

Why(Why did you change it?)

References:

  1. https://bugs.python.org/issue29930
  2. https://vorpus.org/blog/some-thoughts-on-asynchronous-api-design-in-a-post-asyncawait-world/
  3. Graceful shutdown can (I think) truncate connections that it shouldn't aio-libs/aiohttp#1369

@komuw
Copy link
Owner Author

komuw commented May 31, 2019

thanks to the work(blogposts etc) of @njsmith otherwise the fixes in this PR would not have been possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants