Add type to upload secret (#49)

konflux-ci · Aug 3, 2023 · e234c49 · e234c49
1 parent ebbf23f
commit e234c49
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/controllers/component_image_controller.go b/controllers/component_image_controller.go
@@ -441,6 +441,7 @@ func (r *ComponentReconciler) createRemoteSecretUploadSecret(ctx context.Context
 				remotesecretv1beta1.RemoteSecretNameAnnotation: remoteSecretName,
 			},
 		},
+		Type:       corev1.SecretTypeDockerConfigJson,
 		StringData: generateDockerconfigSecretData(imageURL, robotAccount),
 	}
 	if err := r.Client.Create(ctx, uploadSecret); err != nil {

diff --git a/controllers/component_image_controller_test.go b/controllers/component_image_controller_test.go
@@ -178,6 +178,7 @@ var _ = Describe("Component image controller", func() {
 
 			Expect(uploadSecret.Labels[remotesecretv1beta1.UploadSecretLabel]).To(Equal("remotesecret"))
 			Expect(uploadSecret.Annotations[remotesecretv1beta1.RemoteSecretNameAnnotation]).To(Equal(remoteSecretKey.Name))
+			Expect(uploadSecret.Type).To(Equal(corev1.SecretTypeDockerConfigJson))
 
 			uploadSecretDockerconfigJson := string(uploadSecret.Data[corev1.DockerConfigJsonKey])
 			var authDataJson interface{}