Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor secrets linking #130

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Refactor secrets linking #130

merged 1 commit into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. Refactor secrets linking 

    1. when linking secret to SA, don't add it if already present
2. unlink secret from SA upon imageRepository deletion
3. don't link secret anymore to imagePullSecrets (used for the image pod
   is using, task/pipeline bundle image)
4. new option to clean up secret links via spec.credentials.verify-linking
   - It will link secret to service account if link is missing.
   - It will remove duplicate links of secret in service account.
   - It will remove secret from imagePullSecrets in service account.
   - It will unlink secret from service account, if secret doesn't exist (can recreated by using 'regenerate-token').

STONEBLD-2540

Signed-off-by: Robert Cerven <[email protected]>
    @rcerven
    rcerven committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    84ca63f View commit details
    Browse the repository at this point in the history