Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handleNotifications + solve bug #135

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

mavaras
Copy link
Contributor

@mavaras mavaras commented Jul 9, 2024

Description

Refactors handleNotifications and solves a bug that was causing an issue when adding/updating/deleting notifications in a IR resource previously created with no notifications within it.

How has this been tested?

Whole functionality tested by deploying the operator to an Openshift cluster and using a test Quay organization to play with ImageRepository's notifications by testing all the functional workflows.


JIRA: ISV-5058

Copy link

openshift-ci bot commented Jul 9, 2024

Hi @mavaras. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MartinBasti
Copy link

Can you please add description also to commit, not just PR

@mavaras mavaras force-pushed the ISV-4914 branch 2 times, most recently from c771fbb to f450a52 Compare July 10, 2024 08:54
@mmorhun
Copy link
Collaborator

mmorhun commented Jul 10, 2024

/ok-to-test

- Refactors handleNotifications function
- Solves a bug that was causing an issue when adding/updating/deleting notifications in a IR resource previously created with no notification within it.
- Updates integration tests
@mavaras
Copy link
Contributor Author

mavaras commented Jul 11, 2024

/test image-controller-e2e

@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
@mmorhun
Copy link
Collaborator

mmorhun commented Jul 11, 2024

/test image-controller-e2e

@mmorhun mmorhun merged commit cec0ccb into konflux-ci:main Jul 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants