-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handleNotifications + solve bug #135
Conversation
Hi @mavaras. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can you please add description also to commit, not just PR |
c771fbb
to
f450a52
Compare
/ok-to-test |
- Refactors handleNotifications function - Solves a bug that was causing an issue when adding/updating/deleting notifications in a IR resource previously created with no notification within it. - Updates integration tests
/test image-controller-e2e |
/test image-controller-e2e |
Description
Refactors
handleNotifications
and solves a bug that was causing an issue when adding/updating/deleting notifications in a IR resource previously created with no notifications within it.How has this been tested?
Whole functionality tested by deploying the operator to an Openshift cluster and using a test Quay organization to play with ImageRepository's notifications by testing all the functional workflows.
JIRA: ISV-5058