Update README with new API #59
Conversation
| regenerate-token: true | ||
| ... | ||
| ``` | ||
| After token rotation, the `spec.credentials` section will be deleted and `status.credentials.generationTimestamp` updated. |
There was a problem hiding this comment.
Would be good to also mention whether or not and what else will be done accordingly
There was a problem hiding this comment.
I didn't get your point, could you elaborate more on this?
There was a problem hiding this comment.
I mean, except the generationTimestamp is updated, if anything else is also changed, it would be good to mention here as well.
|
|
||
| The key difference from general purpose workflow are: | ||
| - second robot account and corresponding secret created with read (pull) only access to the image repository. | ||
| - the pull secret is propagated into all `Application` environments via `RemoteSecret`. |
There was a problem hiding this comment.
We know that the "environments" means individual deployment environment, staging and prod. Do we need to mention it here explicitly?
Is "Application environments" described in some other document? If yes, it should be good to link to it.
There was a problem hiding this comment.
I looked briefly and failed to find the definition. The closest mention of it is here. Don't think we should include the link above here.
No description provided.