Revert readOnlyRootFilesystem for image_pruner #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image-pruner container needs write on rootFS as it is installing pip packages. Put back write access until image-pruner is changed to not require this access.
Merged
mmorhun
approved these changes
Sep 27, 2023
|
Merging this as a temporary workaround. |
tkdchen
added a commit
to tkdchen/image-controller
that referenced
this pull request
Jan 5, 2024
By replacing requests with urllib, the change can be restored. This reverts commit 2b2e5a5.
tkdchen
added a commit
to tkdchen/image-controller
that referenced
this pull request
Jan 8, 2024
This reverts commit 2b2e5a5.
tkdchen
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image-pruner container needs write on rootFS as it is installing pip packages. Put back write access until image-pruner is changed to not require this access.