Use Remote Secret for storing image repository push token #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
mmorhun
force-pushed
the
STONEBLD-1736
branch
from
7e3880a
to
cad9f8b
Compare
mmorhun
force-pushed
the
STONEBLD-1736
branch
from
cad9f8b
to
e6117a8
Compare
mmorhun
force-pushed
the
STONEBLD-1736
branch
from
e6117a8
to
2416003
Compare
tkdchen
reviewed
Sep 28, 2023
Signed-off-by: Mykola Morhun <[email protected]>
mmorhun
force-pushed
the
STONEBLD-1736
branch
from
2416003
to
5b7e35d
Compare
rcerven
reviewed
Sep 29, 2023
| @@ -500,13 +491,16 @@ func (r *ImageRepositoryReconciler) EnsureRemotePullSecret(ctx context.Context, | |||
| return err | |||
| } | |||
|
|
|||
| serviceAccountName := buildPipelineServiceAccountName | |||
| if isPull { | |||
There was a problem hiding this comment.
why are you using default SA for pull secret?
There was a problem hiding this comment.
Because there is no build pipeline SA in that namespaces and also no guarantee that any other SA exists.
It was discussed during pull secret implementation.
rcerven
reviewed
Sep 29, 2023
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| if isPull { |
There was a problem hiding this comment.
also don't understand why this differs for pull & push secret
There was a problem hiding this comment.
Because push token must be in current (build) namespace only (at least for current requirements), but pull token in all environments of the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs makes push token stored in a RemoteSecret instead of just Secret. Such approach gives the following advantages: