Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robot account already exists handling in quay client #79

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mmorhun
Copy link
Collaborator

@mmorhun mmorhun commented Nov 22, 2023

This PR improves handling of the situation when robot account already exists.
Quay might return error message in message or error_message or error filed of the response along with 400 status code.

@mmorhun mmorhun self-assigned this Nov 22, 2023
@openshift-ci openshift-ci bot requested a review from psturc November 22, 2023 10:32
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

pkg/quay/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mmorhun mmorhun merged commit 6ae4f0b into konflux-ci:main Nov 22, 2023
11 checks passed
@mmorhun mmorhun deleted the STONEBLD-1969 branch November 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants