reporting repository provision request times to prometheus for SLO/SLI

[rcerven]

STONEBLD-1775

[mmorhun]

We can do the deletion only if the time was recorded.

[rcerven]

time will be always recorded at that point

[mmorhun]

Then why do we need that if above?

[rcerven]

I need real time for observe, I don't have to check that something is in map when removing

[rcerven]

I mean in this case I guess I can just move that delete inside if

[tkdchen]

There is duplicate code at line https://github.com/redhat-appstudio/image-controller/pull/84/files#diff-922fcbfbe2565443329918a2b0d49b2b03588007ec6464a20d3feb824f3f80a2R143

I'd suggest to simplify the arguments and make them explicit

func getComponentIdForMetrics(componentName, componentNS string) string {
}

[rcerven]

well that uses different thing and not component

[tkdchen]

Function initMetrics is called twice inside both reconciler SetupWithManager functions. I assume the duplicated calls should not cause any potential problem due to the underlying package handles that. Even though, how about to avoid duplicated call explicitly?

Metrics related code are mainly implemented inside imagerepository_controller.go file and shared with ComponentReconciler. My suggestion is to make a separate go file under package controllers to include those shared code related to metrics.

[mmorhun]

ImageRepository doesn't have to have ComponentNameLabelName label. For example, JBS uses it without the label.
I think we have to have identifier not related to Component, but to instance of ImageRepository itself.

[rcerven]

will use name + namespace then

[rcerven]

Function initMetrics is called twice inside both reconciler SetupWithManager functions. I assume the duplicated calls should not cause any potential problem due to the underlying package handles that. Even though, how about to avoid duplicated call explicitly?

Metrics related code are mainly implemented inside imagerepository_controller.go file and shared with ComponentReconciler. My suggestion is to make a separate go file under package controllers to include those shared code related to metrics.

did you see the first thing I do in initMetrics??

// don't register it if it was already registered by another controller
if imageRepositoryProvisionTimeMetric != nil {
	return nil
}

that ensures it doesn't run multiple times

but I have to call it in both controllers because 1 of them will be first to initialize it

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

[rcerven]

/retest