Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXUI-279): replace Workspace by Namespace only in the UI #94

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JoaoPedroPP
Copy link
Contributor

@JoaoPedroPP JoaoPedroPP commented Jan 21, 2025

Fixes

KFLUXUI-279

Description

Replace all occurrences of Workspace in UI by Namespace

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Current
image

After change
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 7.21649% with 90 lines in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (4609b37) to head (962e31d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/routes/index.tsx 0.00% 90 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   80.11%   79.55%   -0.57%     
==========================================
  Files         570      570              
  Lines       21452    21623     +171     
  Branches     5050     5062      +12     
==========================================
+ Hits        17187    17202      +15     
- Misses       4241     4397     +156     
  Partials       24       24              
Flag Coverage Δ
unittests 79.55% <7.21%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoaoPedroPP JoaoPedroPP marked this pull request as ready for review January 21, 2025 20:07
@JoaoPedroPP
Copy link
Contributor Author

I searched in other places of the UI but apparently this is the only place beside the Workspace switcher, that should have another story.

@JoaoPedroPP JoaoPedroPP force-pushed the KFLUXUI-279 branch 3 times, most recently from 16011d6 to 7993236 Compare January 22, 2025 12:18
@CryptoRodeo
Copy link
Contributor

Would any of these qualify for an update?

  • src/components/PageAccess/NoAccessState.tsx
  • src/components/ReleaseService/ReleasePlan/TriggerRelease/TriggerReleaseForm.tsx
  • src/components/ReleaseService/ReleasePlanAdmission/ReleasePlanAdmissionListHeader.tsx
  • src/components/UserAccess/UserAccessForm/EditAccessPage.tsx
  • src/components/UserAccess/UserAccessForm/UserAccessForm.tsx
  • src/components/UserAccess/UserAccessForm/UsernameSection.tsx
  • src/utils/pipeline-utils.ts

@JoaoPedroPP JoaoPedroPP force-pushed the KFLUXUI-279 branch 2 times, most recently from 51ca090 to f93a288 Compare January 24, 2025 22:02
@JoaoPedroPP
Copy link
Contributor Author

JoaoPedroPP commented Jan 24, 2025

Would any of these qualify for an update?

* `src/components/PageAccess/NoAccessState.tsx`

* `src/components/ReleaseService/ReleasePlan/TriggerRelease/TriggerReleaseForm.tsx`

* `src/components/ReleaseService/ReleasePlanAdmission/ReleasePlanAdmissionListHeader.tsx`

* `src/components/UserAccess/UserAccessForm/EditAccessPage.tsx`

* `src/components/UserAccess/UserAccessForm/UserAccessForm.tsx`

* `src/components/UserAccess/UserAccessForm/UsernameSection.tsx`

* `src/utils/pipeline-utils.ts`

They certainly qualify! Thanks for the close look @CryptoRodeo :)

Code updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants