KFLUXINFRA-1064: testing phase added to merged main branch SeaLights workflow and refactoring for DRY #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uns on the merged main branch and scans it with SeaLights. Refactoring the two testing+SeaLights workflows so that they'll use a unified bash script and keep it DRY
ifireball
reviewed
Dec 31, 2024
|
@meyrevived do we still need this PS given that #372 was merged? |
|
Made differently in #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeaLights asked that we'll add a testing phase to the github workflow that runs a SeaLights code scan on the main branch after it's been merged with new code.
This basically made sealights-mpc-test-ci.yaml extremely similar to this workflow and so I removed all the repeating code to a separate bash script that needs to be given flags depending on where it's run (pull request or merged main) and now the workflows just run this script with its flags.