-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ISV-5571): ignore SBOM-related task errors in rh-advisories #786
base: development
Are you sure you want to change the base?
Conversation
Hi @wcheang. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
591927d
to
0bf90a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am cool with this change, but let's see if Martin is too. It would be nice to set this to yellow (I think that is the unstable status in tekton?) in the pipeline visualization to alert users something happened here, but given I don't know how to do that, not too fair for me to ask you to 🙂
/ok-to-test |
@johnbieren any idea why the tests still haven't started? |
Hmm, no, but retest should start them |
/retest |
/retest |
I don't think Tekton has any option to show a taskrun as yellow. AFAIK, it's a Konflux feature, but not really applicable for our use case, see my comment here: #786 (comment) |
c5fcc15
to
e46a086
Compare
6dd195f
to
4ce6a4e
Compare
Instability in Atlas should not fail the whole pipeline. This change ensures that the pipeline will continue even if the request to upload to Atlas fails. Signed-off-by: Wai Cheang <[email protected]>
/ok-to-test |
Describe your changes
Failing to process or upload SBOMs should not fail the whole rh-advisories pipeline. This change ensures that the pipeline will continue even if there are errors in the SBOM-related tasks.
Relevant Jira
https://issues.redhat.com/browse/ISV-5571
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>