Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ISV-5571): ignore SBOM-related task errors in rh-advisories #786

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

wcheang
Copy link
Contributor

@wcheang wcheang commented Jan 24, 2025

Describe your changes

Failing to process or upload SBOMs should not fail the whole rh-advisories pipeline. This change ensures that the pipeline will continue even if there are errors in the SBOM-related tasks.

Relevant Jira

https://issues.redhat.com/browse/ISV-5571

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Jan 24, 2025

Hi @wcheang. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wcheang wcheang force-pushed the ISV-5571 branch 3 times, most recently from 591927d to 0bf90a9 Compare January 30, 2025 22:24
johnbieren
johnbieren previously approved these changes Jan 31, 2025
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am cool with this change, but let's see if Martin is too. It would be nice to set this to yellow (I think that is the unstable status in tekton?) in the pipeline visualization to alert users something happened here, but given I don't know how to do that, not too fair for me to ask you to 🙂

@johnbieren
Copy link
Collaborator

/ok-to-test

@jedinym
Copy link
Contributor

jedinym commented Feb 3, 2025

@johnbieren any idea why the tests still haven't started?

@johnbieren
Copy link
Collaborator

Hmm, no, but retest should start them

@johnbieren
Copy link
Collaborator

/retest

@johnbieren
Copy link
Collaborator

/retest

@mmalina
Copy link
Contributor

mmalina commented Feb 4, 2025

I am cool with this change, but let's see if Martin is too. It would be nice to set this to yellow (I think that is the unstable status in tekton?) in the pipeline visualization to alert users something happened here, but given I don't know how to do that, not too fair for me to ask you to 🙂

I don't think Tekton has any option to show a taskrun as yellow. AFAIK, it's a Konflux feature, but not really applicable for our use case, see my comment here: #786 (comment)

@wcheang wcheang force-pushed the ISV-5571 branch 2 times, most recently from 6dd195f to 4ce6a4e Compare February 5, 2025 22:57
Instability in Atlas should not fail the whole pipeline. This change
ensures that the pipeline will continue even if the request to upload
to Atlas fails.

Signed-off-by: Wai Cheang <[email protected]>
@mmalina
Copy link
Contributor

mmalina commented Feb 6, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants