-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1324): file-updates internal task uses git resolver #787
Conversation
This commit updates the process-file-updates internal pipeline to call its one task via git resolver. The pipeline itself still uses a cluster resolver, which will be changed in a separate commit. Signed-off-by: Johnny Bieren <[email protected]>
5789159
to
eee8e22
Compare
/retest |
1 similar comment
/retest |
/retest |
/retest |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But same as last time, I think the PR/commit title should be in imperative form.
It seems you were struggling a bit to get a successful e2e run. And now it's there, so I hope you don't mind me merging this. |
Not at all, I appreciate it! |
…flux-ci#787) This commit updates the process-file-updates internal pipeline to call its one task via git resolver. The pipeline itself still uses a cluster resolver, which will be changed in a separate commit. Signed-off-by: Johnny Bieren <[email protected]>
This commit updates the process-file-updates internal pipeline to call its one task via git resolver. The pipeline itself still uses a cluster resolver, which will be changed in a separate commit.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>