feat(RELEASE-1245): make publish index image task idempotent #791
+122
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
happybhati
force-pushed
the
release1245
branch
28 times, most recently
from
480e617 to
36b9367
Compare
happybhati
force-pushed
the
release1245
branch
4 times, most recently
from
c3dd65b to
23e98e1
Compare
Signed-off-by: Happy Bhati <[email protected]>
happybhati
force-pushed
the
release1245
branch
from
23e98e1 to
61dadbe
Compare
mmalina
reviewed
Feb 6, 2025
| (skopeo copy \ | ||
| --all \ | ||
| --preserve-digests \ | ||
| --retry-times "$(params.retries)" \ | ||
| --src-tls-verify=false "${AUTH_PARAM[@]}" \ | ||
| --src-tls-verify=false "${SOURCE_AUTH_ARGS[@]}" \ |
There was a problem hiding this comment.
The --src-tls-verify=false is not great. I wonder if it's needed. Maybe it's because we can't verify registry-proxy properly? Would be good to find out and possibly get rid of this. But it's not really in scope of this change, so consider this optional.
What I do think is that we shouldn't need --tls-verify=false when checking the target image, so maybe at least remove it there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make publish-index-image task idempotent
Relevant Jira
RELEASE-1245
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>