-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLOUDDST-25758): use pubtools-sign and pubtools-pyxis to sign and upload images #808
base: development
Are you sure you want to change the base?
feat(CLOUDDST-25758): use pubtools-sign and pubtools-pyxis to sign and upload images #808
Conversation
Hi @midnightercz. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5b8a3f0
to
bb05b9c
Compare
tasks/internal/request-and-upload-signature/request-and-upload-signature.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the version strings in the yaml files and update the READMEs? Should be a Changes in entry and also the parameters were changed. It isn't clear to me (and not mentioned on the pr) why requester is being removed - I am pretty sure we need that for tracking purposes
tasks/internal/request-and-upload-signature/request-and-upload-signature.yaml
Show resolved
Hide resolved
4147777
to
057e003
Compare
tasks/managed/rh-sign-image/tests/test-rh-sign-image-multiple-components-multi-batch.yaml
Outdated
Show resolved
Hide resolved
tasks/internal/request-and-upload-signature/request-and-upload-signature.yaml
Show resolved
Hide resolved
12d9ec6
to
ea282f6
Compare
internal request request-and-upload-signature was transfered to use pubtools-sign and pubtools-pyxis to sign and upload signatures. With that, internal requests are now called with multiple references and digests. Batch size is limited by params string length which is set by default to 4096. Retry mechanism in signing was also removed as it's already included in pubtools-sign Signed-off-by: Jindrich Luza <[email protected]>
- Updated readmes - fixed pubtools-sign-msg-container-sign mock Signed-off-by: Jindrich Luza <[email protected]>
ea282f6
to
f08081e
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment but otherwise lgtm. The PR is large, so I am going to ask for someone else on my team to review it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
retries: 1
send_retries: 2
in the new task definition. So why is it no longer worth testing that the retries work?
@midnightercz: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-j8dd9 Test results analysis🚨 Error occurred while running the E2E tests, list of failed Spec(s): ➡️ [ Click to view logsPipelineRun managed-2b94v failed Expected : Pipelinerun 'managed-2b94v' didn't succeed\nLogs from failed container 'managed-2b94v-sign-index-image/step-sign-index-image': \nCreating internal-request to sign image:\n- reference=registry.redhat.io/redhat/preview-operator-index:v4.12-bz12345-1740084634\n- manifest_digest=sha256:ce95f780ccf8cb0b2495a9cd35905e0c7d2d8d37b8d1450e689fb65a0540eb15\n- requester=jinqi-1\nInternalRequest 'simple-signing-pipeline-vlvpc' created.\nSync flag set to true. Waiting for the InternalRequest to be completed.\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n simple-signing-pipeline-vlvpc: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n simple-signing-pipeline-vlvpc: Failed\nAll InternalRequests have been completed\nERROR: At least one InternalRequest failed\nConditions:\n simple-signing-pipeline-vlvpc: [{\"lastTransitionTime\":\"2025-02-20T20:57:12Z\",\"message\":\"[User error] Validation failed for pipelinerun internalrequest-b5m9g with error invalid input params for task request-and-upload-signature: missing values for these params which have no default values: [manifest_digests references]\",\"reason\":\"Failed\",\"status\":\"False\",\"type\":\"Succeeded\"}]\nResult: failure\n to equal : ➡️ [ Click to view logsTimed out after 3600.001s. timed out when waiting for the release PipelineRun to be finished for the release snapshot-sample-dekh-hhrq9/dev-release-team-tenant Expected success, but got an error: <*errors.errorString | 0xc001d06fa0>: PipelineRun managed-zw5d9 has still not finished yet { s: "PipelineRun managed-zw5d9 has still not finished yet", } |
Internal request request-and-upload-signature was transfered to use pubtools-sign and pubtools-pyxis to sign and upload signatures. With that, internal requests are now called with multiple references and digests. Batch size is limited by params string length which is set by default to 4096. Retry mechanism in signing was also removed as it's already included in pubtools-sign
Describe your changes
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>