Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize command execution environment #1395

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

kke
Copy link
Contributor

@kke kke commented Jun 10, 2019

Normalize command execution environment.

Cons:

  • Ugly (sudo is now a function because aliases can't be inherited into subshells)
  • Complex conditional logic
  • It's not exactly normalized because of ^

Pros:

  • Even subshells now have the env they're supposed to
  • No need to reconnect
  • Should work on Transport::Local
  • No more env bash --noprofile --norc -x env -i sudo bash --noprofile --norc -s

Might be simpler and saner to create some sort of /usr/local/share/pharos/shell-exec

@kke kke added bug Something isn't working enhancement New feature or request labels Jun 10, 2019
@kke kke changed the title [poc] Normalize command execution [poc] Normalize command execution environment Jun 11, 2019
@kke
Copy link
Contributor Author

kke commented Jun 11, 2019

I wonder what's wrong now, why does the kubectl get nodes after up fail? Is the proxy stuff actually working now and the command doesn't work because of that?

@kke kke changed the title [poc] Normalize command execution environment [wip] Normalize command execution environment Jun 11, 2019
@kke kke changed the title [wip] Normalize command execution environment Normalize command execution environment Jun 12, 2019
@jakolehm jakolehm added this to the 2.4.1 milestone Jun 14, 2019
@jakolehm jakolehm modified the milestones: 2.4.1, 2.4.2 Jun 27, 2019
@jakolehm jakolehm modified the milestones: 2.4.2, 2.4.3, 2.5.0 Aug 6, 2019
@jakolehm
Copy link
Contributor

jakolehm commented Sep 2, 2019

@kke rebase needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants