Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devrel 1127/transform snippets #26

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Devrel 1127/transform snippets #26

merged 5 commits into from
Apr 9, 2024

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral force-pushed the DEVREL-1127/transform_snippets branch 2 times, most recently from 6cacafe to 75d7753 Compare March 19, 2024 11:26
@IvanKiral IvanKiral force-pushed the DEVREL-1127/transform_snippets branch 2 times, most recently from d3b8032 to 820d863 Compare April 2, 2024 08:32
@IvanKiral IvanKiral force-pushed the DEVREL-1127/transform_snippets branch from 72041e9 to 418ad1b Compare April 2, 2024 12:08
@IvanKiral IvanKiral marked this pull request as ready for review April 4, 2024 06:47
@IvanKiral IvanKiral requested review from JiriLojda and a team as code owners April 4, 2024 06:47
JiriLojda
JiriLojda requested changes Apr 5, 2024
View reviewed changes
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
tests/unit/sync/elementTransformers.test.ts Outdated Show resolved Hide resolved
tests/unit/sync/elementTransformers.test.ts Show resolved Hide resolved
tests/unit/sync/elementTransformers.test.ts Show resolved Hide resolved
tests/unit/sync/snippetTransformer.test.ts Outdated Show resolved Hide resolved
src/modules/constants/syncRichText.ts Show resolved Hide resolved
@IvanKiral IvanKiral force-pushed the DEVREL-1127/transform_snippets branch 2 times, most recently from a3728f3 to 812e42f Compare April 8, 2024 07:41
JiriLojda
JiriLojda reviewed Apr 8, 2024
View reviewed changes
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/elementTransformers.ts Outdated Show resolved Hide resolved
src/modules/sync/modelTransfomers/contentTypeSnippets.ts Outdated Show resolved Hide resolved
src/modules/sync/types/syncModel.ts Outdated Show resolved Hide resolved
src/modules/sync/types/syncModel.ts Outdated Show resolved Hide resolved
tests/unit/sync/elementTransformers.test.ts Outdated Show resolved Hide resolved
JiriLojda
JiriLojda approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion, otherwise it looks nice.

src/modules/sync/modelTransfomers/elementTransformers.ts Outdated
return term;
}

return term.terms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Now the function can be a single expression using one ternary operator. 😉

@IvanKiral IvanKiral force-pushed the DEVREL-1127/transform_snippets branch from bc504a9 to f167172 Compare April 9, 2024 06:36
@IvanKiral IvanKiral merged commit 9867e69 into sync Apr 9, 2024
3 checks passed
@IvanKiral IvanKiral deleted the DEVREL-1127/transform_snippets branch April 9, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriLojda JiriLojda JiriLojda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanKiral @JiriLojda