Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devrel 1202/files validation #78

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Devrel 1202/files validation #78

merged 9 commits into from
Oct 1, 2024

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral force-pushed the DEVREL-1202/files_validation branch 2 times, most recently from a4d73b6 to 960b03d Compare September 23, 2024 12:08
@IvanKiral IvanKiral marked this pull request as ready for review September 25, 2024 08:54
@IvanKiral IvanKiral requested review from JiriLojda and a team as code owners September 25, 2024 08:54
JiriLojda
JiriLojda requested changes Sep 25, 2024
View reviewed changes
src/utils/types.ts Outdated Show resolved Hide resolved
src/modules/sync/utils/getContentModel.ts Outdated Show resolved Hide resolved
src/modules/sync/utils/getContentModel.ts Outdated Show resolved Hide resolved
src/modules/sync/validation/elementSchemas.ts Outdated Show resolved Hide resolved
src/utils/types.ts Outdated Show resolved Hide resolved
src/modules/sync/validation/entitySchema.ts Outdated Show resolved Hide resolved
src/modules/sync/validation/entitySchema.ts Outdated Show resolved Hide resolved
src/modules/sync/validation/entitySchema.ts Outdated Show resolved Hide resolved
tests/unit/syncModel/validation/languageSchema.test.ts Outdated Show resolved Hide resolved
tests/unit/syncModel/validation/languageSchema.test.ts Outdated Show resolved Hide resolved
JiriLojda
JiriLojda reviewed Sep 30, 2024
View reviewed changes
src/modules/sync/validation/elementSchemas.ts Outdated Show resolved Hide resolved
src/utils/types.ts Outdated Show resolved Hide resolved
src/modules/sync/validation/elementSchemas.ts Outdated Show resolved Hide resolved
@IvanKiral IvanKiral merged commit 5b6ae4c into main Oct 1, 2024
3 checks passed
@IvanKiral IvanKiral deleted the DEVREL-1202/files_validation branch October 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriLojda JiriLojda JiriLojda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanKiral @JiriLojda