Add asset codename #250
Merged
Add asset codename #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirO-kontent
requested review from
pokornyd,
gormal and
a team
as code owners
Sevitas
suggested changes
Aug 17, 2023
| @@ -71,10 +71,13 @@ public async Task GetAssetAsync_StronglyTyped_ById_GetsAsset() | |||
| [Fact] | |||
| public async Task GetAssetAsync_StronglyTyped_ByCodename_Throws() | |||
There was a problem hiding this comment.
Suggested change
| public async Task GetAssetAsync_StronglyTyped_ByCodename_Throws() | |
| public async Task GetAssetAsync_StronglyTyped_ByCodename_GetsAsset() |
There was a problem hiding this comment.
Shouldn't by asset codename also work for renditions as well?
There was a problem hiding this comment.
Yes, I have missed it in one test. The others should still throw since renditions themselves don't have codenames, only assets do.
VladimirO-kontent
force-pushed
the
Add_asset_codename
branch
from
0a32a92
to
8e3dd02
Compare
Sevitas
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 84.39% 84.44% +0.04%
==========================================
Files 246 246
Lines 2807 2816 +9
Branches 315 315
==========================================
+ Hits 2369 2378 +9
Misses 343 343
Partials 95 95
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pokornyd
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #249
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?