Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN-125 Add due date to content item variant #262

Conversation

arguit
Copy link

@arguit arguit commented Mar 27, 2024

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@arguit arguit requested review from pokornyd and a team as code owners March 27, 2024 06:52
Copy link
Contributor

@VladimirO-kontent VladimirO-kontent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update PutLanguageVariant in CmApiV2.cs.

/// <summary>
/// Represents due date model.
/// </summary>
public class DueDateResponseModel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is also used in requests, it should not have response in name.

@pokornyd pokornyd force-pushed the EN-125-mapi-improvement-set-due-date-in-content-variant branch from 9885c0d to eb677c6 Compare April 8, 2024 10:21
@pokornyd pokornyd merged commit 5ab22f2 into kontent-ai:master Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants