EN-376 Add contributors and note to language variants #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokornyd
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
PR mentions only due date being added to Change workflow endpoint, but it appears much more's been added in the end. nothing wrong with that, just wanted to clarify the extent the endpoint is being modified and if it's retaining its name in API reference (otherwise the underlying method should likely be renamed too). suggested a minor formatting change, otherwise looks good
| /// <param name="workflowStepIdentifier">Workflow step identifier to set.</param> | ||
| Task ChangeLanguageVariantWorkflowAsync(LanguageVariantIdentifier identifier, WorkflowStepIdentifier workflowStepIdentifier); | ||
| /// <param name="changeModel">Change language variant workflow model.</param> | ||
| Task ChangeLanguageVariantWorkflowAsync(LanguageVariantIdentifier identifier, ChangeLanguageVariantWorkflowModel changeModel); |
There was a problem hiding this comment.
will this endpoint still be called "Change the workflow of a language variant" in the API reference? if not, shouldn't the method be renamed?
| @@ -2025,7 +2025,15 @@ public async void PutVariantWorkflow() | |||
| var exception = await Record.ExceptionAsync(async () => | |||
| await client.ChangeLanguageVariantWorkflowAsync( | |||
| new LanguageVariantIdentifier(itemIdentifier, languageIdentifier), | |||
| new WorkflowStepIdentifier(Reference.ById(Guid.Empty), workflowStepIdentifier) | |||
| new ChangeLanguageVariantWorkflowModel(Reference.ById(Guid.Empty), workflowStepIdentifier) | |||
There was a problem hiding this comment.
Since this file is apparently used for code samples, I'd probably fix the formatting here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal is to support contributors and notes in language variants. This includes the enhancement of "change-workflow" endpoint that where the due date was also added.
Checklist
How to test
If manual testing is required, what are the steps?