-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up automated formatting #95
Set up automated formatting #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8e5b879
to
ae478a4
Compare
@petrsvihlik After a bit of difficulty resolving the conflicts, I ended up having to perform a reset on my branch to reflect the changes made in #94. From there I was able to reintegrate the autoformatting as before. Let me know if you have any questions. |
it looks good to me :) thank you @cbeard87! would you be interested in another JS or other issue? we can suggest you some that we need help with. |
@petrsvihlik Absolutely! Just let me know where I can help out and I'll be more than happy to jump in. |
@cbeard87 I guess you're mostly interested in JS projects. You can hae a look at our priorities. I'd suggest either: The second issue says it's blocked by https://github.com/Enngage/kentico-cloud-js/issues/52 but I think the preview URL generation logic can be build as a part of the sample app and extracted as a separate package later on. Please let me know if some of the issues caught your eye. :) |
Hey @cbeard87, we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG! Please fill out your postal address if you are interested. This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once. Kentico Developer Community If there’s anything we can do to help, please don’t hesitate to reach out to us at [email protected] |
To avoid ejecting from the create-react-app build tool, the official recommendations for setting up automated code formatting (found here) were followed.
Uses prettier for code formatting
Uses husky and lint-staged to set up Githook formatting automation
Adds eslintrc.json to enable in-editor linting
Closes #84