✨ Deduplicating Labels (#296)

This pull request addresses issue #295. I resolved the problem, of duplicate labels appearing both in violations and rules after adding labels from the ruleset, by introducing a function that flags all duplicate values within the labels array. @pranavgaikwad please check. --------- Signed-off-by: AdiAkhileshSingh15 <[email protected]>
konveyor · Aug 23, 2023 · 8af6167 · 8af6167
1 parent 20ec4dc
commit 8af6167
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/engine/engine.go b/engine/engine.go
@@ -492,6 +492,8 @@ func (r *ruleEngine) createViolation(conditionResponse ConditionResponse, rule R
 		}
 	}
 
+	rule.Labels = deduplicateLabels(rule.Labels)
+
 	return konveyor.Violation{
 		Description: rule.Description,
 		Labels:      rule.Labels,
@@ -558,3 +560,18 @@ func matchesAllSelectors(m RuleMeta, selectors ...RuleSelector) bool {
 	}
 	return true
 }
+
+func deduplicateLabels(labels []string) []string {
+	present := map[string]bool{}
+	uniquelabels := []string{}
+
+	for _, label := range labels {
+		if !present[label] {
+			present[label] = true
+			uniquelabels = append(uniquelabels, label)
+		}
+	}
+
+	return uniquelabels
+
+}