Merge branch 'konveyor:main' into 301-unify-conditional-interface-imp…

…lementations-to-either-use-value-or-pointer-types

cmd/analyzer/main.go

@@ -67,6 +67,8 @@ func init() {
 func main() {
 	if err := rootCmd.Execute(); err != nil {
 		println(err.Error())
+	} else if rootCmd.Flags().Changed("help") {
+		return
 	}
 
 	// This will globally prevent the yaml library from auto-wrapping lines at 80 characters

engine/engine.go

@@ -406,15 +406,6 @@ func (r *ruleEngine) createViolation(conditionResponse ConditionResponse, rule R
 			lineNumber := *m.LineNumber
 			incident.LineNumber = &lineNumber
 		}
-		links := []konveyor.Link{}
-		if len(m.Links) > 0 {
-			for _, l := range m.Links {
-				links = append(links, konveyor.Link{
-					URL:   l.URL,
-					Title: l.Title,
-				})
-			}
-		}
 		// Some violations may not have a location in code.
 		limitSnip := (r.codeSnipLimit != 0 && fileCodeSnipCount[string(m.FileURI)] == r.codeSnipLimit)
 		if !limitSnip {
@@ -492,6 +483,8 @@ func (r *ruleEngine) createViolation(conditionResponse ConditionResponse, rule R
 		}
 	}
 
+	rule.Labels = deduplicateLabels(rule.Labels)
+
 	return konveyor.Violation{
 		Description: rule.Description,
 		Labels:      rule.Labels,
@@ -558,3 +551,18 @@ func matchesAllSelectors(m RuleMeta, selectors ...RuleSelector) bool {
 	}
 	return true
 }
+
+func deduplicateLabels(labels []string) []string {
+	present := map[string]bool{}
+	uniquelabels := []string{}
+
+	for _, label := range labels {
+		if !present[label] {
+			present[label] = true
+			uniquelabels = append(uniquelabels, label)
+		}
+	}
+
+	return uniquelabels
+
+}