✨ Generic Provider #266
Merged
✨ Generic Provider #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
requested changes
Jul 21, 2023
external-providers/generic-external-provider/pkg/generic/dependency.go
Outdated
Show resolved
Hide resolved
fabianvf
reviewed
Jul 21, 2023
external-providers/generic-external-provider/pkg/generic/dependency.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Chanakya-TS
force-pushed
the
genericProvider
branch
from
9a96b4c
to
46a52cf
Compare
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
fabianvf
requested changes
Jul 26, 2023
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
fabianvf
requested changes
Jul 27, 2023
external-providers/generic-external-provider/pkg/generic/provider.go
Outdated
Show resolved
Hide resolved
…ncorrect copying, updated documentation Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Chanakya-TS
force-pushed
the
genericProvider
branch
from
7642680
to
1186c0e
Compare
…rovider Signed-off-by: Chanakya Thirumala Setty <[email protected]>
fabianvf
reviewed
Aug 2, 2023
docs/experimental/python-provider.md
Outdated
| pip install jedi-langauge-server | ||
| ``` | ||
|
|
||
| It will be installed in `/home/<user_name>/.local/bin/jedi-language-server` |
There was a problem hiding this comment.
you could also add the example config/sample main.py/example rule just for the sake of completeness
fabianvf
approved these changes
Aug 2, 2023
pranavgaikwad
requested changes
Aug 2, 2023
| return nil, nil | ||
| } | ||
| m := map[uri.URI][]*provider.Dep{} | ||
| json.Unmarshal([]byte(data), &m) |
There was a problem hiding this comment.
Handle unmarshal error
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
Signed-off-by: Chanakya Thirumala Setty <[email protected]>
| } | ||
|
|
||
| m := map[uri.URI][]*provider.Dep{} | ||
| for u, d := range ll { | ||
| m[u] = provider.ConvertDagItemsToList(d) | ||
| } | ||
|
|
||
| return m, err | ||
| jsonStr, err := json.Marshal(m) |
There was a problem hiding this comment.
okay, ignore above, just spoke with Fabian
pranavgaikwad
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic provider that can be used to create an external provider for any language that is compliant with LSP 3.17 specifications.
Adds
goprovider that is initialized using the generic provider binary.