Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Update go mod in generic external provider #326

Merged
merged 2 commits into from
Sep 13, 2023
Merged

🐛 Update go mod in generic external provider #326

merged 2 commits into from
Sep 13, 2023

Conversation

pranavgaikwad
Copy link
Contributor

Fixes #325

@pranavgaikwad
update go mod
62838cf 
Signed-off-by: Pranav Gaikwad <[email protected]>
jmontleon
jmontleon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@pranavgaikwad pranavgaikwad changed the title Update go mod in generic external provider 🐛 Update go mod in generic external provider Sep 11, 2023
@shawn-hurley
Copy link
Contributor

Looks like this is blowing up the dependencies in the demo the change looks fine, but we probably need to dig into that

@pranavgaikwad
Copy link
Contributor Author

yeah, investigating now.

@pranavgaikwad
update analyzer-lsp dep
acb5048 
Signed-off-by: Pranav Gaikwad <[email protected]>
@pranavgaikwad
Copy link
Contributor Author

pranavgaikwad commented Sep 11, 2023 •
edited
Loading

@shawn-hurley this breakage has nothing to do with change in this PR. Actually, the dep is broken in the base image, we can't find go binary somehow. Check this failure that happened after merging your old PR https://github.com/konveyor/analyzer-lsp/actions/runs/6148484915/job/16682284146

@jmontleon
Copy link
Member

It's my fault, overzealous cleanup. https://github.com/konveyor/java-analyzer-bundle/pull/66/files

@fbladilo
Copy link
Contributor

Are we good now? re-kick CI?

@pranavgaikwad pranavgaikwad merged commit 46fc5b7 into konveyor:main Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmontleon jmontleon jmontleon approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go mod file in generic external provider has unnecessary replace directive
4 participants
@pranavgaikwad @shawn-hurley @jmontleon @fbladilo