✨ Adding ability to snip files and make all konveyor-jdt into file URI's #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
commented
Sep 12, 2023
shawn-hurley
force-pushed
the
feature/convert-bundle-uri-to-file
branch
from
b6d3009
to
9228515
Compare
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/convert-bundle-uri-to-file
branch
from
9228515
to
ee5f1a7
Compare
shawn-hurley
changed the title
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/convert-bundle-uri-to-file
branch
from
04a1833
to
851c799
Compare
pranavgaikwad
approved these changes
Sep 14, 2023
| s := strings.TrimSuffix(jarName, ".jar") | ||
| s = fmt.Sprintf("%v-sources.jar", s) | ||
| jarPath = filepath.Join(filepath.Dir(u.Path), s) | ||
| } else { |
There was a problem hiding this comment.
interesting, so we did find the solution for non source?
There was a problem hiding this comment.
I don't know if this is working as intended and/or fixes the full problem. It does solve the other big problem that folks are bringing up, so it is worth getting in, and then I will add some follow up after testing tomorrow to see how off it all is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.