🐛 remove json marshaling that's not working #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added
the
cherry-pick/release-0.3
eemcmullan
approved these changes
Apr 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
This is not working, and actually making static report generation fail.
This is the error I see because of the custom MarshalJSON() function:
```
json: error calling MarshalJSON for type RuleSet: json: error calling MarshalJSON for type konveyor.Violation: json: unsupported type: map[interface {}]interface {}
```
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
pranavgaikwad
added a commit
that referenced
this pull request
Apr 17, 2024
This is not working, and actually making static report generation fail.
This is the error I see because of the custom MarshalJSON() function:
```
json: error calling MarshalJSON for type RuleSet: json: error calling MarshalJSON for type konveyor.Violation: json: unsupported type: map[interface {}]interface {}
```
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Pranav Gaikwad <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not working, and actually making static report generation fail.
This is the error I see because of the custom MarshalJSON() function: