✨ adding reflection client to determine what provider provides #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
feature/add-location-grpc-services
branch
4 times, most recently
from
8d039d3
to
9a92350
Compare
|
This is breaking because we are not updating the external providers to use the updated code in analyzer-lsp during the build here. going to try and fix this |
shawn-hurley
force-pushed
the
feature/add-location-grpc-services
branch
2 times, most recently
from
3890234
to
1d49ab2
Compare
shawn-hurley
commented
Apr 23, 2024
| @@ -1,15 +1,18 @@ | |||
| # Build the manager binary | |||
| FROM golang:1.21 as builder | |||
There was a problem hiding this comment.
Need to downgrade to 1.20
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-location-grpc-services
branch
from
671b52f
to
b823117
Compare
|
Hey @pranavgaikwad @eemcmullan I am really sorry this feature PR turned into a catch all PR fixing CI, making all the docker files build with same go as well as the feature. if you really want, I can make more commits to make it easier to review but let me know what you think |
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-location-grpc-services
branch
3 times, most recently
from
ee9f682
to
1b30f6a
Compare
pranavgaikwad
approved these changes
Apr 24, 2024
eemcmullan
approved these changes
Apr 24, 2024
| @@ -25,6 +28,6 @@ RUN npm install -g typescript-language-server typescript | |||
| RUN go install golang.org/x/tools/gopls@latest | |||
|
|
|||
| COPY --from=go-builder /generic-external-provider/generic-external-provider /usr/local/bin/generic-external-provider | |||
| COPY --from=go-dep-provider /usr/local/bin/go-dependency-provider /usr/local/bin/go-dependency-provider | |||
| COPY --from=go-dep-provider /usr/local/bin/golang-dependency-provider /usr/local/bin/golang-dependency-provider | |||
There was a problem hiding this comment.
Note: will need to update this in kantra now. I can do so. I just don't want to forget
| @@ -1,13 +1,15 @@ | |||
| FROM golang:1.20 as go-builder | |||
|
|
|||
| copy / /analyzer-lsp | |||
There was a problem hiding this comment.
I don't think so, I think that is moving the / context into /analyzer-lsp in the image.
| } | ||
| } | ||
|
|
||
| func checkServicesRunning(refClt *reflectClient.Client, log logr.Logger) ([]string, error) { |
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-location-grpc-services
branch
from
1b30f6a
to
d784948
Compare
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
DRAFT FOR NOW
initial implementation some TODO's left want to see what CI gives me