✨ Gradle support #591
Closed
✨ Gradle support #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
requested changes
May 6, 2024
external-providers/java-external-provider/pkg/java_external_provider/dependency.go
Outdated
Show resolved
Hide resolved
| func (p *javaServiceClient) GetDependencies(ctx context.Context) (map[uri.URI][]*provider.Dep, error) { | ||
| if p.getBuildTool() == gradle { |
There was a problem hiding this comment.
is this redundant given that there's a switch in GetDepenenciesDAG()? I think we will need to move fallback call inside GetDepenciesDAG()
There was a problem hiding this comment.
I think it's a good idea to have the check here too, mainly because both GetDependencies and GetDependenciesDAG are public, so they could both be called independently
jmle
force-pushed
the
gradle-support
branch
2 times, most recently
from
21000b1
to
0a753ec
Compare
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Merged
|
Superseded by #609 |
jmle
added a commit
that referenced
this pull request
Jun 3, 2024
👀 See [Gradle support enhancement](https://github.com/konveyor/enhancements/blob/master/enhancements/gradle-support/README.md) (#598) Adds support for fetching dependencies with Gradle projects. (#599) Adds support for downloading dependency sources. - This implementation assumes that there is a Gradle wrapper included in the project, otherwise it is not possible to know which Gradle version is needed. - To maximize compatibility with most Gradle versions, JDK8 must be used. There are a number of ways to specify this on newer Gradle versions, but for older versions the only thing that seems to work is setting `JAVA_HOME`. :exclamation: This PR supersedes #591 🟢 Tested against https://github.com/andyjduncan/gradle-example and https://github.com/kissaten/gradle-multi-project-example --------- Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#598) Adds support for fetching dependencies with Gradle projects.
JAVA_HOME.❗ This PR does not provide support for fetching dependency sources yet.
🟢 Tested against https://github.com/andyjduncan/gradle-example and https://github.com/kissaten/gradle-multi-project-example