✨ add ability to pass maven coordinate in location #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
approved these changes
Jun 12, 2024
docs/providers.md
Outdated
| @@ -92,7 +92,7 @@ Here's an example config for `java` provider that is currently in-tree and does | |||
| } | |||
| ``` | |||
|
|
|||
| The `location` can be a path to the application's source code or to a binary JAR, WAR, or EAR file. | |||
| The `location` can be a path to the application's source code or to a binary JAR, WAR, or EAR file. Optionally, coordinates to a maven artifact can be provided as input in the format `mvn://<group-id>.<artifact-id>:<version>:<classifier>:<path>`. The field `<path>` is optional, it specifies a local path where the artifact will be downloaded. If not specified, provider will use a temporary directory to download it. | |||
There was a problem hiding this comment.
can we use something like @ or something that is not a part of a common URI for the path part?
There was a problem hiding this comment.
This is a minor concern
jmle
approved these changes
Jun 12, 2024
| if strings.HasPrefix(config.Location, MvnURIPrefix) { | ||
| mvnUri := strings.Replace(config.Location, MvnURIPrefix, "", 1) | ||
| // URI format is <group>:<artifact>:<version>:<classifier>:<path> | ||
| // <path> is optional & points to a local path where it will be downloaded |
There was a problem hiding this comment.
Is the classifier mandatory in the URL?
There was a problem hiding this comment.
@jmle yeah, in the hub UI, we have four fields including classifier (defaulted to JAR). I think I will default to JAR too if one isn't specified
There was a problem hiding this comment.
@jmle done, defaulting to jar now
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
shawn-hurley
approved these changes
Jun 13, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554