🐛 Fix chaining in Java provider #721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
jmle
commented
Nov 14, 2024
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
This reverts commit cb8dbf8.
This reverts commit cc85616.
shawn-hurley
approved these changes
Nov 15, 2024
| @@ -611,7 +611,7 @@ func templateCondition(condition []byte, ctx map[string]engine.ChainTemplate) ([ | |||
| s := strings.ReplaceAll(string(condition), `'{{`, "{{") | |||
| s = strings.ReplaceAll(s, `}}'`, "}}") | |||
|
|
|||
| s, err := mustache.Render(s, true, ctx) | |||
| s, err := mustache.RenderRaw(s, true, ctx) | |||
There was a problem hiding this comment.
Why render raw vs render just for my knowledge :)
There was a problem hiding this comment.
We were calling the Render method passing true as a second parameter, but the signature of Render doesn´t have a bool parameter. RenderRaw has, and I thought there was some reason in the past to use RenderRaw but the invocation was done mistakenly by calling Render instead...
There was a problem hiding this comment.
Thanks! that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #718