-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Enable use of a proposed api in dev mode #222
Conversation
Considering the above - perhaps we should switch to merge editor as the default? |
Probably best so the extension can be published... We'll probably needs some processing in the copy scripts to filter out commands that hook the proposed APIs so the built extension is "clean". |
3a89e9e
to
7e8d643
Compare
In development mode, to avoid errors being displayed about proposed API use: - Add the proposed API to the extension's `package.json` so it can be activated from the vscode cli - Add the cli switch to the dev launcher.json config Note: According to [1], an extension using a proposed api cannot be published. More exploration is needed to see how we can support using the proposed api via `.vsix` install but also create a package that can be published to the extension store. [1] - https://code.visualstudio.com/api/advanced-topics/using-proposed-api Signed-off-by: Scott J Dickerson <[email protected]>
7e8d643
to
d151aa0
Compare
The `diff` view requires use of proposed APIs. Swap the default to the one that will both work without special measures and will let the extension be published to the extension markplace. Ref: konveyor#222 Signed-off-by: Scott J Dickerson <[email protected]>
The `diff` view requires use of proposed APIs. Swap the default to the one that will both work without special measures and will let the extension be published to the extension markplace. Ref: #222 Note: This change does not remove the proposed api use warnings vscode shows at startup. Signed-off-by: Scott J Dickerson <[email protected]>
@konveyor/kai-ide-reviewers -- We should put this in regardless and deal with publishability to a marketplace in the future. This PR will just make life a little nicer for us right now. |
In development mode, to avoid errors being displayed about proposed API use:
package.json
so it can be activated from the vscode cliNote: According to [1], an extension using a proposed api cannot be published. More exploration is needed to see how we can support using the proposed api via
.vsix
install but also create a package that can be published to the extension store.[1] - https://code.visualstudio.com/api/advanced-topics/using-proposed-api