Default to containerless mode #376
Conversation
eemcmullan
force-pushed
the
set-env
branch
2 times, most recently
from
e679b18
to
c9792e0
Compare
There was a problem hiding this comment.
Thanks for the PR! Left few comments, CI probably needs some care, otherwise looks good.
General note on the default containerless, since there is also default analyze mode "full" (to analyze source+dependencies), analysis results might be different than before since there is persisted Maven .m2 cache with packages. So, even without adding settings.xml file to the analyze command, some packages might be already present in the local maven repository cache and some rules can match on those.
| @@ -200,12 +201,9 @@ func NewAnalyzeCmd(log logr.Logger) *cobra.Command { | |||
| defer stop() | |||
|
|
|||
| // ***** RUN CONTAINERLESS MODE ***** | |||
| if Settings.RunLocal { | |||
| if analyzeCmd.listProviders { | |||
There was a problem hiding this comment.
--list-providers should return instead of starting analysis with container-less/run_local.
There was a problem hiding this comment.
Didn't realize I removed that. Thanks for catching
Signed-off-by: Emily McMullan <[email protected]>
default to containerless mode Signed-off-by: Emily McMullan <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
Fixes https://issues.redhat.com/browse/MTA-4217 and https://issues.redhat.com/browse/MTA-4219