feat: use podman for building custom images if executable is found #1101
Conversation
|
Thanks for making a pull request! 😃 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 14.91% 14.90% -0.01%
==========================================
Files 90 90
Lines 8380 8384 +4
==========================================
Hits 1250 1250
- Misses 6805 6809 +4
Partials 325 325 ☔ View full report in Codecov by Sentry. |
| if err == nil { | ||
| return "podman" | ||
| } | ||
| return "docker" |
There was a problem hiding this comment.
Can we also log a message at level info here that "Couldn't find Podman executable in the directories named by the PATH environment variable. Using Docker as the container runtime.
| // GetDefaultContainerRuntime returns the preferred container runtime of the host | ||
| func GetDefaultContainerRuntime() string { | ||
| _, err := exec.LookPath("podman") | ||
| if err == nil { |
There was a problem hiding this comment.
Can we log a message at level info here that "Podman executable found in the directories named by the PATH environment variable. Using Podman as the container runtime.
HarikrishnanBalagopal
added
the
lfx-project
|
Raised a new PR for this feat. #1157 Work done in this PR:
cc: @Akash-Nayak |
Signed-off-by: Soumil Paranjpay <[email protected]>
HarikrishnanBalagopal
force-pushed
the
feat/enhanced-podman-support
branch
from
c2a5b40
to
9ee0a17
Compare
No description provided.