Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for mergeDeletionCallBack #1118

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

satyazzz123
Copy link
Contributor

tests for mergeDeletionCallback

i) This test case covers a scenario when function is called with a non-existent source file and an existing destination directory

fixes a part of #881

Copy link

github-actions bot commented Dec 9, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@seshapad seshapad changed the title test : add tests for mergeDeletionCallBack test: add tests for mergeDeletionCallBack Dec 10, 2023
@github-actions github-actions bot added the test label Dec 10, 2023
@seshapad
Copy link
Member

seshapad commented Dec 10, 2023

@satyazzz123 License is missing from the file. Please add it and address the lint issues. Please check for lint issues by running make ci.

Signed-off-by: satyazzz123 <[email protected]>
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e88cece) 14.81% compared to head (9acf886) 14.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   14.81%   14.86%   +0.04%     
==========================================
  Files          90       90              
  Lines        8321     8321              
==========================================
+ Hits         1233     1237       +4     
+ Misses       6770     6766       -4     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @satyazzz123 for the contribution, please feel free to add more test cases to this test function and also cover other functions in this file.
cc @seshapad

@kmehant kmehant merged commit 445020f into konveyor:main Dec 10, 2023
3 checks passed
@satyazzz123
Copy link
Contributor Author

Thanks @satyazzz123 for the contribution, please feel free to add more test cases to this test function and also cover other functions in this file. cc @seshapad

Yess I am working on the other tests soon will raise another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants