-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Test tasks tab in detail drawer #1242
base: main
Are you sure you want to change the base?
[Draft] Test tasks tab in detail drawer #1242
Conversation
Hi @EstyBiton. Thanks for your PR. I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!! 😄
I left some minor improvements
cypress/e2e/tests/migration/task-manager/application_tasks_tab.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/task-manager/application_tasks_tab.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/task-manager/application_tasks_tab.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/task-manager/application_tasks_tab.test.ts
Outdated
Show resolved
Hide resolved
Updated the code based on feedback. Thank you! |
Signed-off-by: EstyBiton <[email protected]>
Signed-off-by: EstyBiton <[email protected]>
…eedback. Signed-off-by: EstyBiton <[email protected]>
Signed-off-by: EstyBiton <[email protected]>
020a59a
to
67278fa
Compare
Signed-off-by: EstyBiton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 😃
@sshveta, @abrugaro please note that this PR should be merged after: konveyor/tackle2-ui#2123 |
Add Tests for Tasks Tab in Application Drawer ,The tests ensure that the Task Kind column accurately displays the expected task types after performing an analysis.
tasks kind:
Language Discovery
Tech Discovery
Analyzer
screenshot after test: