Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] adapt some selectors for crud + create-tracker tests to work #666

Merged
merged 3 commits into from
Aug 14, 2023
Merged

[RFR] adapt some selectors for crud + create-tracker tests to work #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3587a5b
[RFR] adapt some selectors for crud test to work
Neilhamza Aug 13, 2023
cc89ff8
adapted more selector
Neilhamza Aug 13, 2023
641b426
remove cypress config from the PR
Neilhamza Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/views/applicationinventory.view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
export const actionButton = "div > button[aria-label='Actions']";
export const actionButton = "button[aria-label='Kebab toggle']";
export const applicationNameInput = "input[name=name]";
export const applicationDescriptionInput = "input[name=description]";
export const applicationBusinessServiceSelect = "[placeholder='Select a business service']";
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/views/common.view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const controlsForm = "form.pf-v5-c-form";
export const itemsPerPageMenu = "div.pf-c-options-menu";
export const itemsPerPageMenuOptions = "ul.pf-v5-c-menu__list";
export const expandRow = "button[aria-label=Details]";
export const successAlertMessage = "div[aria-label='Success Alert']";
export const successAlertMessage = ".pf-m-success";
export const infoAlertMessage = "div[aria-label='Info Alert']";
export const duplicateNameWarning = "h4[class*='alert__title']";
export const appTable = "table[aria-label='main-table']";
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/views/migration-wave.view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export enum MigrationWaveView {
waveTable = "table[aria-label='Migration waves table']",
createTrackerButton = "#create-tracker",
waveExpanded = "pf-m-expanded",
removeApplicationButton = ".pf-u-text-align-right > button",
removeApplicationButton = ".pf-v5-u-text-align-right > button",
}

export enum MigrationWavesSpecialColumns {
Expand Down
1 change: 0 additions & 1 deletion cypress/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,6 @@ export function deleteApplicationTableRows(): void {
.closest(trTag)
.within(() => {
click(actionButton);
cy.wait(800);
})
.contains(button, deleteAction)
.then(($delete_btn) => {
Expand Down
Loading